Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Svelte 5 #88

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
d620463
init monorepo
huntabyte Aug 4, 2024
1bf0e30
initialization stuff
huntabyte Aug 4, 2024
79706a3
progress
huntabyte Aug 4, 2024
e67d68c
more work
huntabyte Aug 4, 2024
c165de0
bit more
huntabyte Aug 4, 2024
6ba065c
more
huntabyte Aug 4, 2024
b988fca
more
huntabyte Aug 5, 2024
420e678
more
huntabyte Aug 5, 2024
52fd205
portal is the problem
huntabyte Aug 5, 2024
a70097c
it works
huntabyte Aug 5, 2024
32d4233
cleanup navigation resets
huntabyte Aug 5, 2024
dbafaae
more
huntabyte Aug 5, 2024
7248e0b
export types
huntabyte Aug 5, 2024
d824061
another
huntabyte Aug 5, 2024
eb09f5e
update
huntabyte Aug 5, 2024
9c1faed
we try again
huntabyte Aug 5, 2024
ba5d6d4
we try again
huntabyte Aug 6, 2024
7ebe641
more
huntabyte Aug 6, 2024
98da6e3
idk
huntabyte Aug 6, 2024
1127425
wow
huntabyte Aug 6, 2024
5668178
more next
huntabyte Aug 6, 2024
2c0971f
more
huntabyte Aug 6, 2024
61792a4
better scroll removal
huntabyte Aug 6, 2024
9c31b92
working: scrollbar removal - before attempting to disablePreventScroll
huntabyte Aug 6, 2024
1ed27db
working: disable prevent scroll
huntabyte Aug 6, 2024
6917149
id things
huntabyte Aug 6, 2024
ed3195e
update bits
huntabyte Sep 24, 2024
60c4845
next:update deps
huntabyte Oct 2, 2024
2c9fdc3
next 2
huntabyte Oct 7, 2024
bf80ed8
next 2 2
huntabyte Oct 7, 2024
0cd4343
finally
huntabyte Oct 8, 2024
c0e7b6d
getting closer gotta figure out snappoint issue
huntabyte Oct 8, 2024
9a2dda0
still issues with immediate close on open snap points
huntabyte Oct 8, 2024
84fb302
fix open immediate close issue
huntabyte Oct 8, 2024
e785c7a
lfg!
huntabyte Oct 8, 2024
436c0fe
cleanup
huntabyte Oct 8, 2024
187c0f4
more
huntabyte Oct 8, 2024
07d3e03
next: enter prerelease mode (#93)
huntabyte Oct 9, 2024
2538e22
merge main
huntabyte Oct 9, 2024
1a6a0a8
Version Packages (next) (#94)
github-actions[bot] Oct 9, 2024
77583ad
next: fix scroll restoration (#98)
huntabyte Oct 27, 2024
e961847
Version Packages (next) (#99)
github-actions[bot] Oct 27, 2024
4c17bad
next: update bits (#103)
huntabyte Nov 4, 2024
9cbae95
Version Packages (next) (#104)
github-actions[bot] Nov 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": []
"ignore": ["docs"]
}
5 changes: 5 additions & 0 deletions .changeset/large-chairs-promise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vaul-svelte": patch
---

update bits UI
5 changes: 5 additions & 0 deletions .changeset/polite-apples-attend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vaul-svelte": patch
---

update bits
14 changes: 14 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"mode": "pre",
"tag": "next",
"initialVersions": {
"vaul-svelte": "0.3.2",
"docs": "0.0.0"
},
"changesets": [
"large-chairs-promise",
"polite-apples-attend",
"sharp-actors-fly",
"sour-trainers-boil"
]
}
5 changes: 5 additions & 0 deletions .changeset/sharp-actors-fly.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vaul-svelte": patch
---

next: fix scroll restoration
5 changes: 5 additions & 0 deletions .changeset/sour-trainers-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vaul-svelte": major
---

Svelte 5
16 changes: 0 additions & 16 deletions .eslintignore

This file was deleted.

77 changes: 0 additions & 77 deletions .eslintrc.cjs

This file was deleted.

94 changes: 47 additions & 47 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,50 +1,50 @@
name: "🐛 Bug report"
name: 🐛 Bug report
description: Report an issue with vaul-svelte
labels: ["type: bug"]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
- type: textarea
id: bug-description
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is. If you intend to submit a PR for this issue, tell us how in the description. Thanks!
placeholder: Bug description
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: Reproduction
description: Please provide a link to a repo or Stackblitz that can reproduce the problem you ran into. If a report is vague (e.g. just a generic error message) and has no reproduction, it will receive a "need reproduction" label. If no reproduction is provided within a reasonable time-frame, the issue will be closed.
placeholder: Reproduction
validations:
required: true
- type: textarea
id: logs
attributes:
label: Logs
description: "Please include browser console and server logs around the time this bug occurred. Optional if provided reproduction. Please try not to insert an image but copy paste the log text."
render: bash
- type: textarea
id: system-info
attributes:
label: System Info
description: Output of `npx envinfo --system --npmPackages svelte,bits-ui,vaul-svelte,@sveltejs/kit,typescript --binaries --browsers`
render: bash
placeholder: System, Binaries, Browsers
validations:
required: true
- type: dropdown
id: severity
attributes:
label: Severity
description: Select the severity of this issue
options:
- annoyance
- blocking an upgrade
- blocking all usage of vaul-svelte
validations:
required: true
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
- type: textarea
id: bug-description
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is. If you intend to submit a PR for this issue, tell us how in the description. Thanks!
placeholder: Bug description
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: Reproduction
description: Please provide a link to a repo or Stackblitz that can reproduce the problem you ran into. If a report is vague (e.g. just a generic error message) and has no reproduction, it will receive a "need reproduction" label. If no reproduction is provided within a reasonable time-frame, the issue will be closed.
placeholder: Reproduction
validations:
required: true
- type: textarea
id: logs
attributes:
label: Logs
description: Please include browser console and server logs around the time this bug occurred. Optional if provided reproduction. Please try not to insert an image but copy paste the log text.
render: bash
- type: textarea
id: system-info
attributes:
label: System Info
description: Output of `npx envinfo --system --npmPackages svelte,bits-ui,vaul-svelte,@sveltejs/kit,typescript --binaries --browsers`
render: bash
placeholder: System, Binaries, Browsers
validations:
required: true
- type: dropdown
id: severity
attributes:
label: Severity
description: Select the severity of this issue
options:
- annoyance
- blocking an upgrade
- blocking all usage of vaul-svelte
validations:
required: true
34 changes: 17 additions & 17 deletions .github/ISSUE_TEMPLATE/documentation_change.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@ name: 📖 Report Docs Issue
description: Suggest an addition or modification to the documentation
labels: ["type: documentation"]
body:
- type: dropdown
attributes:
label: Change Type
description: What type of change are you proposing?
options:
- Addition
- Correction
- Removal
- Cleanup (formatting, typos, etc.)
validations:
required: true
- type: dropdown
attributes:
label: Change Type
description: What type of change are you proposing?
options:
- Addition
- Correction
- Removal
- Cleanup (formatting, typos, etc.)
validations:
required: true

- type: textarea
attributes:
label: Proposed Changes
description: Describe the proposed changes and why they are necessary
validations:
required: true
- type: textarea
attributes:
label: Proposed Changes
description: Describe the proposed changes and why they are necessary
validations:
required: true
40 changes: 20 additions & 20 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@ name: 🛠️ Request New Feature
description: Let us know what you would like to see added.
labels: ["type: feature"]
body:
- type: textarea
id: description
attributes:
label: Describe the feature in detail (code, mocks, or screenshots encouraged)
validations:
required: true
- type: dropdown
id: category
attributes:
label: What type of pull request would this be?
options:
- "New Feature"
- "Enhancement"
- "Guide"
- "Docs"
- "Other"
- type: textarea
id: references
attributes:
label: Provide relevant links or additional information.
- type: textarea
id: description
attributes:
label: Describe the feature in detail (code, mocks, or screenshots encouraged)
validations:
required: true
- type: dropdown
id: category
attributes:
label: What type of pull request would this be?
options:
- New Feature
- Enhancement
- Guide
- Docs
- Other
- type: textarea
id: references
attributes:
label: Provide relevant links or additional information.
33 changes: 33 additions & 0 deletions .github/workflows/build-preview.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Build Preview Deployment

# cancel in-progress runs on new commits to same PR (github.event.number)
concurrency:
group: ${{ github.workflow }}-${{ github.event.number || github.sha }}
cancel-in-progress: true

on:
pull_request:
types: [opened, synchronize]

jobs:
build-preview:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: 20
cache: pnpm

- name: Install dependencies
run: pnpm install

- name: Build site
run: pnpm build

- name: Upload build artifact
uses: actions/upload-artifact@v4
with:
name: preview-build
path: sites/docs/.svelte-kit/cloudflare
Loading