paginate to return items, getAll to use concurrency#2
Open
jlcampbell1991 wants to merge 4 commits intomasterfrom
Open
paginate to return items, getAll to use concurrency#2jlcampbell1991 wants to merge 4 commits intomasterfrom
jlcampbell1991 wants to merge 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hunterashaw This is a rough draft and I'd want to make some more changes before committing.
I have two goals in mind. One is to avoid state mutation, which is why I removed
paginate()'s callback function and changed it to return an array of items. I'd like to find a way to refactorresandcurrentso that we don't reassign their values.Second is to take advantage of BC's concurrency limit. I've used Bluebird's Promise.map function. There may be a better function to use in this case. It requires a mapper function as an argument, but we don't need to transform our array, so mapper just returns the value untransformed.