Convert paginate to an AsyncGenerator to allow efficient use of data as it comes in#6
Open
LordZardeck wants to merge 2 commits intohunterashaw:masterfrom
Open
Convert paginate to an AsyncGenerator to allow efficient use of data as it comes in#6LordZardeck wants to merge 2 commits intohunterashaw:masterfrom
paginate to an AsyncGenerator to allow efficient use of data as it comes in#6LordZardeck wants to merge 2 commits intohunterashaw:masterfrom
Conversation
Collaborator
|
Conceptually, I really like the idea. I feel like it would make it feel and perform significantly faster. I'd want to make sure to test it thoroughly first (which I'm sure you've already done some, @LordZardeck), but I'm all for merging it if it doesn't create any new issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would solve #5
After looking into the code more i realized that technically you can achieve the same result through the
eachPageparameter, but I feel this is a cleaner useThis also adds the ability to know where in the query we are by returning a tuple of the page items, and the current page, and total. Ideally, we might just return the meta itself so we can have an exact understanding of how many items we are getting in total, not just the pages