[HOTFIX] Migration 148 is now "idempotent" (#6236)

* migration 148 is now "idempotent" * bump version
huridocs · Nov 6, 2023 · 50141a3 · 50141a3
1 parent 58c15d6
commit 50141a3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/app/api/migrations/migrations/148-update_translations/index.js b/app/api/migrations/migrations/148-update_translations/index.js
@@ -57,9 +57,11 @@ export default {
   async up(db) {
     const settings = await db.collection('settings').findOne();
     const languages = settings.languages.map(l => l.key);
-    await db
-      .collection('translationsV2')
-      .deleteMany({ key: { $in: deletedKeys.map(k => k.key) }, 'context.id': 'System' });
+
+    await db.collection('translationsV2').deleteMany({
+      key: { $in: deletedKeys.concat(newKeys).map(k => k.key) },
+      'context.id': 'System',
+    });
 
     const insertMany = languages.map(l =>
       db.collection('translationsV2').insertMany(

diff --git a/app/api/migrations/migrations/148-update_translations/specs/148-update_translations.spec.js b/app/api/migrations/migrations/148-update_translations/specs/148-update_translations.spec.js
@@ -43,4 +43,8 @@ describe('migration update translations of settings new Users/Groups UI', () =>
 
     expect(translations.length).toBe(newKeys.length * fixtures.settings[0].languages.length);
   });
+
+  it('should be idempotent (do not throw an error on multiple runs)', async () => {
+    await expect(migration.up(testingDB.mongodb)).resolves.toBe(undefined);
+  });
 });
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "uwazi",
-  "version": "1.141.0",
+  "version": "1.141.1",
   "description": "Uwazi is a free, open-source solution for organising, analysing and publishing your documents.",
   "keywords": [
     "react"