WIP, prevent client crash when ix extractor has no templates

huridocs · Jul 18, 2024 · c50e777 · c50e777
1 parent 0f96181
commit c50e777
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/app/api/services/informationextraction/ixextractors.ts b/app/api/services/informationextraction/ixextractors.ts
@@ -116,6 +116,7 @@ export const Extractors = {
     await createBlankSuggestionsForExtractor(saved);
     return saved;
   },
+
   update: async (id: string, name: string, property: string, templateIds: string[]) => {
     const [extractor] = await model.get({ _id: new ObjectId(id) });
     if (!extractor) throw Error('Missing extractor.');

diff --git a/app/api/suggestions/specs/eventListeners.spec.ts b/app/api/suggestions/specs/eventListeners.spec.ts
@@ -1055,7 +1055,7 @@ describe(`On ${TemplateDeletedEvent.name}`, () => {
     expect(suggestions).toEqual([]);
   });
 
-  it('should not act if the feature is not enabld', async () => {
+  it('should not act if the feature is not enabled', async () => {
     await disableFeatures();
 
     const suggestions = await testingDB.mongodb?.collection('ixsuggestions').find({}).toArray();

diff --git a/app/react/V2/Routes/Settings/IX/components/SuggestionsTitle.tsx b/app/react/V2/Routes/Settings/IX/components/SuggestionsTitle.tsx
@@ -23,7 +23,10 @@ const SuggestionsTitle = ({
   onFiltersButtonClicked: () => void;
   activeFilters: number;
 }) => {
-  const allProperties = [...(templates[0].commonProperties || []), ...templates[0].properties];
+  const allProperties = [
+    ...(templates[0]?.commonProperties || []),
+    ...(templates[0]?.properties || []),
+  ];
   const template = allProperties.find(prop => prop.name === property);
 
   let propGraphics: string | React.ReactNode = '_';

diff --git a/app/react/V2/Routes/Settings/IX/components/TableElements.tsx b/app/react/V2/Routes/Settings/IX/components/TableElements.tsx
@@ -241,7 +241,10 @@ const suggestionsTableColumnsBuilder: Function = (
   acceptSuggestions: (suggestions: TableSuggestion[]) => void,
   openPdfSidepanel: (suggestion: TableSuggestion) => void
 ) => {
-  const allProperties = [...(templates[0].commonProperties || []), ...templates[0].properties];
+  const allProperties = [
+    ...(templates[0]?.commonProperties || []),
+    ...(templates[0]?.properties || []),
+  ];
 
   return [
     suggestionColumnHelper.accessor('entityTitle', {