fixed a bug when using rename on upload files

huridocs · Sep 8, 2020 · d5860bc · d5860bc
1 parent b64f38a
commit d5860bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/api/files/uploadMiddleware.ts b/app/api/files/uploadMiddleware.ts
@@ -7,7 +7,9 @@ import { promisify } from 'util';
 
 type multerCallback = (error: Error | null, destination: string) => void;
 
-const rename = promisify(fs.rename);
+const copyFile = promisify(fs.copyFile);
+const removeFile = promisify(fs.unlink);
+
 const defaultStorage = multer.diskStorage({
   filename(_req: Request, file: Express.Multer.File, cb: multerCallback) {
     cb(null, generateFileName(file));
@@ -17,7 +19,8 @@ const defaultStorage = multer.diskStorage({
 const move = async (req: Request, filePath: pathFunction) => {
   const oldPath = path.join(req.file.destination, req.file.filename);
   const newPath = filePath(req.file.filename);
-  await rename(oldPath, newPath);
+  await copyFile(oldPath, newPath);
+  await removeFile(oldPath);
   req.file.destination = filePath();
   req.file.path = filePath(req.file.filename);
 };

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "uwazi",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "description": "Uwazi is a free, open-source solution for organising, analysing and publishing your documents.",
   "main": "server.js",
   "repository": {