AT entity creation event listener fix #7387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not using permissions commandContext anymore, the listener gets executed in the same context as the entity creation, we are only separating this into a event listener / use case to decouple v1 and v2 codes. for some reason some of the entity saves at this point ocury without the entities having _id even though they where already created and in this case the special permission commandId gets replaced on the entities leaving them "corrupted" with a wrong id. this pr fixes the issue because we do not need to use the commandContext, but the original issue causing this potentially remains and should be understood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not using permissions commandContext anymore, the listener gets executed in the same context as the entity creation, we are only separating this into a event listener / use case to decouple v1 and v2 codes.
for some reason some of the entity saves at this point ocury without the entities having _id even though they where already created and in this case the special permission commandId gets replaced on the entities leaving them "corrupted" with a wrong id.
this pr fixes the issue because we do not need to use the commandContext, but the original issue causing this potentially remains and should be understood.