Full-Resolution Camera Downloads #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geeoon
force-pushed
the
full-resolution-camera-download
branch
from
4880522
to
470151e
Compare
abhaybd
requested changes
Jul 18, 2024
Comment on lines
95
to
96
| } else if (message.type === "cameraFrameReport") { | ||
| if (message.data !== "") { |
There was a problem hiding this comment.
Should be combined into else if (message.type === ... && message.data === ...)
| document.body.appendChild(link); | ||
| link.click(); | ||
| document.body.removeChild(link); | ||
|
|
README.md
Outdated
| { | ||
| type: "cameraFrameReport", | ||
| camera: string, | ||
| data: string | null |
There was a problem hiding this comment.
Under what circumstances would data be null? If there's no data, is it simpler to just not send back a camera frame report?
abhaybd
requested changes
Jul 20, 2024
README.md
Outdated
| @@ -380,6 +380,38 @@ Sent from the rover server to inform Mission Control of a single frame of a came | |||
| - `camera` - the name of the camera: `mast|hand|wrist` | |||
| - `data` - the raw h264 frame data, or `null` if no data is available | |||
|
|
|||
| ## Camera Frame Request | |||
| ### Description | |||
| Sent from Mission Control to instruct the rover server to send a Camera Frame Report. | |||
There was a problem hiding this comment.
Super minor, but mention how this works with the report. I.e. "If camera specifies a valid camera stream, the rover will respond with a camera frame report containing the latest frame from that camera."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking the download button will just download the client-side H264 compressed stream, which is fairly low quality. This PR adds the ability to request full-resolution jpg images from the rover, and if the camera is available, a base64 encoded image will be sent to mission control at a much higher resolution than the normal client-side video stream.
Related with huskyroboticsteam/Resurgence#331