Skip to content

feat: playlist management support #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
huynhsontung wants to merge 34 commits into
base: main
Choose a base branch
from
Open

feat: playlist management support #514

huynhsontung wants to merge 34 commits into from

Conversation

@huynhsontung
Copy link
Owner

@huynhsontung huynhsontung commented Dec 21, 2024 •
edited
Loading

Closes #110, closes #596

image image

@huynhsontung huynhsontung mentioned this pull request Sep 29, 2025
Merged
@huynhsontung huynhsontung marked this pull request as ready for review February 8, 2026 06:52
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Feb 8, 2026
@huynhsontung
Copy link
Owner Author

huynhsontung commented Feb 8, 2026

@United600 Can you take a quick look at this PR and let me know what you think? I think the core functionality of the playlist system is complete. There are some outstanding UX polish items, such as raising a notification when a playlist is created or an item is added to an existing playlist via the context menu, but this PR is getting too big. I'm considering opening a new PR for UX polishes.

@United600
Copy link
Collaborator

United600 commented Feb 9, 2026

Feature wise is in a good state.

Why was JSON chosen for the playlist save file format? I'm not a fan of it. We should adopt a format that works across all applications. In the absence of an official standard, the best approach is to use the most widely supported format, and currently that's .m3u8.
A XML-based format would be ideal, but I don't think XSPF or SMIL are as widely used/supported.

The save location should be more convenient/accessible, the main music library folder (plus some "Playlists" or similar named folder) should be the default destination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@United600 United600 Awaiting requested review from United600

Assignees

Copilot code review Copilot

Labels

enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Addition of Playlist Feature Playlists support

3 participants

@huynhsontung @United600