fix: rapid current item changing that break UI transitions #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting current item to null on playlist clear result to unnecessary updates to current item currentItem = item1 -> null -> item2 rapid updates like this breaks UI transitions
dosubot
bot
added
size:L
Collaborator
|
Found another way to trigger the issue, and this time it wasn't a regression. Gravacao.2025-10-18.143358.mp4 |
VideoView opacity should only be set by ContentStates group
Audio state looks cleaner when empty
Owner
Author
73312b9 should fix it now |
Collaborator
I've never seen a stranger solution than this one 😂 |
Owner
Author
|
It's a wonderful world of XAML 🌈 |
Collaborator
😩 I won't stand for XAML slander! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#676 introduced a regression where the current item is first changed to
nullwhen changing playlists. As a result, the current item can change fromitem1tonulltoitem2, instead of going fromitem1directly toitem2. This extra value change in rapid succession causes some UI logics to break.