-
-
Notifications
You must be signed in to change notification settings - Fork 119
feat: add settings privacy section #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d2995b4 to
6dba683
Compare
6dba683 to
970d967
Compare
Disagree. If we want to show all the entries in the playback position history it should be outside of the SettingsExpander. Perhaps a popup. Anyway it's out of scope for this PR. |
4fb95f0 to
a3aa0a1
Compare
|
@United600 I made |
Can confirm the cache is now being disposed of correctly. |
|
May be unrelated, but what do you think of using the "progression" or "media progression" term instead of the "last position" term? |
Probably better. |
|
I also wonder, should it be limited to video files? And is this last position "format" conducive to be added as a progress bar to the ‘CommonGridViewItem’? |
|
Should I merge the resume and remember playback position cards? If so, which one do you prefer? No InfoBar is also an option. Gravacao.2026-02-01.145045.mp4Gravacao.2026-02-01.145351.mp4 |
|
If the "Always resume" option is under the "Playback position" expander, then I don't think we need to explain why the option is disabled. I thought the "Always resume" option would remain in the General section. This ordering works as well, and we don't need to deal with extra explanation. |
Let's implement this in a separate PR. |
In most cases, I agree that this feature only makes sense with video files. But I think we should artificially limit this feature because it works in most cases. Perhaps we can make the "Always resume" option only affect video files. That option may break the music listening experience if turned on. |
Yeah, it does makes sense for audiobooks (and podcasts). Though our support for them isn't exactly stellar. |
Just nitpicking: the description for "Playback position" is a bit wordy, and the first-person usage is... odd. Otherwise, it's good. I don't mind shipping it as-is. |
|
The 1424cdd commit moves and updates the "Always resume" setting. If the change doesn't feel right to you, I'll go ahead and revert it (or some parts). |



Privacysettings sectionShow recentcard to thePrivacysectionRemember playback positionsettingFileServiceto respect theShowRecentsettingCloses #771