fix: subtitle auto-loading regression from PR #676 #746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #676 removed
NeighboringFilesQueryfrom thePlaylistmodel, breaking subtitle auto-detection for videos.CompositeTrackPickerViewModelcould no longer access the file query needed to search for subtitle files matching the video filename in the same directory.Changes
Pass
NeighboringFilesQuerythrough message pipeline:NeighboringFilesQueryproperty toPlaylistCurrentItemChangedMessageMediaListViewModelto include_neighboringFilesQuerywhen sending the messageCompositeTrackPickerViewModel.GetSubtitlesForFile()to accept and use the query from the messageRestore original subtitle detection logic:
This reuses the existing query from the playlist rather than creating a new one, matching pre-#676 behavior while maintaining the architectural improvements.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
crl.godaddy.com/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Screenbox/.codeql-scratch/dbs/csharp/working/3256F08C1671F9FA0FA5343B5C71D01D/missingpackages_workingdir --packages /home/REDACTED/work/Screenbox/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/Screenbox/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)ocsp.godaddy.com/usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Screenbox/.codeql-scratch/dbs/csharp/working/3256F08C1671F9FA0FA5343B5C71D01D/missingpackages_workingdir --packages /home/REDACTED/work/Screenbox/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/Screenbox/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.