Skip to content

Commit

Permalink
Disable fault injection with BatchedOpsStressTest and MultiOpsTxnsStr…
Browse files Browse the repository at this point in the history
…essTest (facebook#12794)

Summary:
**Context/Summary:**

facebook#12713 accidentally turned on fault injection in BatchedOpsStressTest and MultiOpsTxnsStressTest. Though this was meant to be an increased testing coverage, it also made our CI noisy. For now we decided to disable it before we manage to stabilize the CI and fix bugs surfaced in NonBatchedOpsStressTest which impacts more users.

Pull Request resolved: facebook#12794

Test Plan: CI

Reviewed By: cbi42

Differential Revision: D58897598

Pulled By: hx235

fbshipit-source-id: 8094072ef1bff27d7825efed0876f365a31fef9c
  • Loading branch information
hx235 authored and facebook-github-bot committed Jun 22, 2024
1 parent 3ee4d5a commit d6cf9de
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions tools/db_crashtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,11 @@ def finalize_and_sanitize(src_params):
if dest_params["test_batches_snapshots"] == 1:
dest_params["enable_compaction_filter"] = 0
dest_params["inplace_update_support"] = 0
# TODO(hx235): enable test_batches_snapshots with fault injection after stabilizing the CI
dest_params["write_fault_one_in"] = 0
dest_params["metadata_write_fault_one_in"] = 0
dest_params["read_fault_one_in"] = 0
dest_params["metadata_read_fault_one_in"] = 0
if dest_params["prefix_size"] < 0:
dest_params["prefix_size"] = 1

Expand Down Expand Up @@ -815,6 +820,12 @@ def finalize_and_sanitize(src_params):
# Wide-column pessimistic transaction APIs are initially supported for
# WriteCommitted only
dest_params["use_put_entity_one_in"] = 0
# TODO(hx235): enable test_multi_ops_txns with fault injection after stabilizing the CI
if dest_params.get("test_multi_ops_txns") == 1:
dest_params["write_fault_one_in"] = 0
dest_params["metadata_write_fault_one_in"] = 0
dest_params["read_fault_one_in"] = 0
dest_params["metadata_read_fault_one_in"] = 0
# Wide column stress tests require FullMergeV3
if dest_params["use_put_entity_one_in"] != 0:
dest_params["use_full_merge_v1"] = 0
Expand Down

0 comments on commit d6cf9de

Please sign in to comment.