Navigation data are now stored and updated in Bebop.navData#16
Navigation data are now stored and updated in Bebop.navData#16fbergama wants to merge 3 commits intohybridgroup:masterfrom
Conversation
gps/pitch/yaw/roll/altitude packets are parsed and stored in drone object upon received. Additionally, "navdata" event is emitted.
|
Hi, @fbergama thanks for this PR. A couple things: first, have you seen #12 yet? It is about to get merged into master branch, so would be a better place to start from. Also, the build failed in your branch, due to problems with failing the linter. Please run Thank you. |
|
Sorry, I was working to expose the navigation data for a personal project and I've seen #12 only after submitting my PR. I suppose that my small addition will be obsolete after merging. Anyway, may it be useful to emit a single event when the navigation data changes (either gps, altitude etc) instead of flooding with many different specialised events (one for altitude, one for gps etc)? |
|
Yes, I agree that as a simplified ARDrone compatible interface, it has value. Once the other PR is in place, perhaps you would be so kind as to recreate this? Thanks again for helping out. |
|
something like this might be a good approach. |
|
I agree that we can easily group all the navigation-related events into a common alias, as johan suggested. I was wondering if there exists an event for each navigation property.. for instance, I cannot see a change event for the speed. |
|
There is one called SpeedChanged. But you have to check the readme for the pull request repository |
|
Ok, I'll wait for this major update and eventually submit a new PR.
|
gps/pitch/yaw/roll/altitude packets are parsed and stored in Bebop
object upon received. Additionally, "navdata" event is emitted.