Skip to content

Comments

Navigation data are now stored and updated in Bebop.navData#16

Open
fbergama wants to merge 3 commits intohybridgroup:masterfrom
fbergama:master
Open

Navigation data are now stored and updated in Bebop.navData#16
fbergama wants to merge 3 commits intohybridgroup:masterfrom
fbergama:master

Conversation

@fbergama
Copy link

gps/pitch/yaw/roll/altitude packets are parsed and stored in Bebop
object upon received. Additionally, "navdata" event is emitted.

gps/pitch/yaw/roll/altitude packets are parsed and stored in drone
object upon received. Additionally, "navdata" event is emitted.
@deadprogram
Copy link
Member

Hi, @fbergama thanks for this PR.

A couple things: first, have you seen #12 yet? It is about to get merged into master branch, so would be a better place to start from.

Also, the build failed in your branch, due to problems with failing the linter. Please run grunt lint locally and you will see what needs to be changed.

Thank you.

@fbergama
Copy link
Author

Sorry, I was working to expose the navigation data for a personal project and I've seen #12 only after submitting my PR. I suppose that my small addition will be obsolete after merging.

Anyway, may it be useful to emit a single event when the navigation data changes (either gps, altitude etc) instead of flooding with many different specialised events (one for altitude, one for gps etc)?

@deadprogram
Copy link
Member

Yes, I agree that as a simplified ARDrone compatible interface, it has value. Once the other PR is in place, perhaps you would be so kind as to recreate this? Thanks again for helping out.

@johan-olsson
Copy link
Contributor

something like this might be a good approach.

@fbergama
Copy link
Author

I agree that we can easily group all the navigation-related events into a common alias, as johan suggested. I was wondering if there exists an event for each navigation property.. for instance, I cannot see a change event for the speed.

@johan-olsson
Copy link
Contributor

There is one called SpeedChanged. But you have to check the readme for the pull request repository

@fbergama
Copy link
Author

Ok, I'll wait for this major update and eventually submit a new PR.

On 20 gen 2016, at 23:49, Johan Olsson notifications@github.com wrote:

There is one called SpeedChanged. But you have to check the readme for the pull request repository


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants