Skip to content

Conversation

emmadesilva
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5667a4e) 98.03% compared to head (b135972) 98.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage     98.03%   98.03%           
  Complexity       29       29           
=========================================
  Files             6        6           
  Lines           102      102           
=========================================
  Hits            100      100           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva added the halt-matrix-tests Internal label to halt full suite matrix testing label Dec 13, 2023
@emmadesilva emmadesilva force-pushed the add-self-update-feature branch from 973521c to 4e2817a Compare December 13, 2023 09:54
@emmadesilva emmadesilva marked this pull request as draft December 13, 2023 11:31
@emmadesilva
Copy link
Member Author

This depends on laravel-zero/framework#481 which seems to be quite stale. Gonna try to create a custom implementation.

@emmadesilva emmadesilva changed the title Add self update feature Add an experimental self update feature Apr 16, 2024
@emmadesilva emmadesilva marked this pull request as ready for review April 16, 2024 19:28
@emmadesilva
Copy link
Member Author

In the future we'll want to add RSA code signing (where we can embed the public key into the Phar) to guard against MITM attacks, but I think this is fair for an initial experimental proof of concept.

@emmadesilva emmadesilva merged commit 7e5a3c2 into master Apr 16, 2024
@emmadesilva emmadesilva deleted the add-self-update-feature branch April 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant