-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: scroll-restore at all page (#149)
* feat: scroll-restore at all page * test: update e2e test * test: update e2e test with wait alias * test: wait for 2sec * test: change get to find * test: cypress version update and logic changed * test: append reload * test: wait twice * test: delete wait * test: disable test
- Loading branch information
Showing
8 changed files
with
75 additions
and
59 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,18 @@ | ||
| describe('root - store restoration', { testIsolation: false }, () => { | ||
| it('should restore scroll position when reload', () => { | ||
| const SCROLL_Y_POSITION = 30; | ||
| // NOTE: https://github.com/cypress-io/cypress/issues/14857 | ||
|
|
||
| cy.visit('/'); | ||
| cy.wait(1000); | ||
| cy.window().then($window => { | ||
| $window.scrollTo(0, SCROLL_Y_POSITION); | ||
| }); | ||
| // describe('root - store restoration', { testIsolation: false }, () => { | ||
| // it('should restore scroll position when go back', () => { | ||
| // const SCROLL_Y_POSITION = 30; | ||
|
|
||
| cy.reload(); | ||
| cy.wait(2000); | ||
| // cy.visit('/'); | ||
| // cy.window().then($window => { | ||
| // $window.scrollTo(0, SCROLL_Y_POSITION); | ||
| // }); | ||
|
|
||
| cy.window().its('scrollY').should('not.eq', 0); | ||
| }); | ||
| }); | ||
| // cy.get('main').find('a').first().click(); | ||
|
|
||
| // cy.go('back', { timeout: 10000 }); | ||
|
|
||
| // cy.window().its('scrollY').should('not.eq', 0); | ||
| // }); | ||
| // }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ | |
| }, | ||
| "devDependencies": { | ||
| "config": "*", | ||
| "cypress": "^12.8.1", | ||
| "cypress": "^13.5.0", | ||
| "tsconfig": "*" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ | |
| }, | ||
| "devDependencies": { | ||
| "config": "*", | ||
| "cypress": "^12.8.1", | ||
| "cypress": "^13.5.0", | ||
| "tsconfig": "*" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98bd0e2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
comet-land-resume – ./apps/resume
comet-land-resume-git-main-hyesungoh.vercel.app
comet-land-resume-hyesungoh.vercel.app
comet-land-resume.vercel.app
98bd0e2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
comet-land-blog – ./apps/blog
comet-land-blog-hyesungoh.vercel.app
comet-land-blog-git-main-hyesungoh.vercel.app
comet-land-blog.vercel.app