Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate expo config plugins #2768

Merged
merged 1 commit into from
Jun 13, 2024
Merged

chore: migrate expo config plugins #2768

merged 1 commit into from
Jun 13, 2024

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Jun 13, 2024

Resolve #2749

@hyochan hyochan added the 🚽 migration Activities due to changes in framework label Jun 13, 2024

This comment was marked as off-topic.

@hyochan
Copy link
Owner Author

hyochan commented Jun 13, 2024

Risk Level 2 - /home/runner/work/react-native-iap/react-native-iap/plugin/build/withIAP.js

  1. The added import statements for 'expo/config-plugins' are redundant. You can import 'createRunOncePlugin' and 'withAppBuildGradle' in a single line to improve readability.
const { withAppBuildGradle, withProjectBuildGradle, createRunOncePlugin, WarningAggregator } = require('expo/config-plugins');
  1. The added warning messages in 'withIAP' function are useful for debugging and user feedback. Ensure that these warnings are not too verbose in production environments.

🔄📄⚠️

Powered by Code Review GPT

It is related to build files so skipped it!

@hyochan hyochan merged commit 82fcce6 into main Jun 13, 2024
4 checks passed
@hyochan hyochan deleted the migration/expo-config branch June 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚽 migration Activities due to changes in framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Plugin imports from @expo/config-plugins instead of expo/config-plugins
1 participant