Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/index sales value and other missing columns #254

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

Jipperism
Copy link
Collaborator

No description provided.

…s columns to sales table

- Introduced new columns to the sales table to store currency amounts, fee amounts as an array, and fee recipients as an array.
Copy link

github-actions bot commented Jan 24, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 27.07% (🎯 26%) 1668 / 6161
🟢 Statements 27.07% (🎯 26%) 1668 / 6161
🟢 Functions 70.9% (🎯 70%) 39 / 55
🟢 Branches 74.02% (🎯 72%) 114 / 154
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/parsing/parseTakerBidEvent.ts 100% 95.83% 100% 100%
src/storage/storeTakerBid.ts 42.77% 100% 0% 42.77% 67-161
Generated in workflow #210 for commit ba8c9ba by the Vitest Coverage Report Action

Copy link
Contributor

@bitbeckers bitbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fast turnover. Added some comments. Especially for the script I think we should try to not allow any edge cases or unexpected behaviour to pass through.

scripts/update_sales_values.ts Outdated Show resolved Hide resolved
scripts/update_sales_values.ts Outdated Show resolved Hide resolved
scripts/update_sales_values.ts Outdated Show resolved Hide resolved
src/parsing/parseTakerBidEvent.ts Outdated Show resolved Hide resolved
src/storage/storeTakerBid.ts Show resolved Hide resolved
@bitbeckers bitbeckers added the enhancement New feature or request label Jan 26, 2025
…tails

- Updated `parseTakerBidEvent` to include parsing of currency amount, fee amounts, and fee recipients.
- Refactored transaction log handling to support HypercertExchange and ERC20 ABI.
- Expanded `TakerBid` schema in `storeTakerBid` to accommodate new fields for currency and fees.
@Jipperism Jipperism force-pushed the feat/index-sales-value-and-other-missing-columns branch from 9b75502 to b7d2eeb Compare January 27, 2025 17:27
- this script will retroactively update existing rows in the sales table of supabase to contain fee_amounts, fee_recipients and currency_amount
- it will also update any hypercert_id's that erronously ended up with an 'undefined' for the token ID
@Jipperism Jipperism force-pushed the feat/index-sales-value-and-other-missing-columns branch from b7d2eeb to ba8c9ba Compare January 27, 2025 17:36
@bitbeckers bitbeckers self-requested a review January 27, 2025 22:08
@Jipperism Jipperism merged commit 3e79245 into develop Jan 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants