util: add a channel body #140
Conversation
|
the msrv action failed here: https://github.com/hyperium/http-body/actions/runs/12635582609/job/35249835531 the relevant bit of our manifest getting in the way is the 4a5b234 removes this syntax, to be backwards compatible with older rust versions. |
|
ah, i just saw that #128 was merged yesterday. i've rebased on top of that, so we can use the |
see: hyperium#140 (comment) this commit adds test coverage exposing the bug, and tightens the pattern used to match frames yielded by the data channel. now, when the channel is closed, a `None` will flow onwards and poll the error channel. `None` will be returned when the error channel is closed, which also indicates that the associated `Sender` has been dropped.
|
i see the MRSV listed in conversely, the logs in the failing action above mention using the 1.49 toolchain, here: my understanding is that this is because #128 did not update the http-body/http-body/Cargo.toml Line 26 in 98d0886 do you have a preference between: (a) respecting a 1.49 MSRV, restoring the changes in the commit mentioned above, or (b) updating the MSRV of |
|
Ah, interesting. I think that's happened is that cargo hack will check both MSRV versions set, but the error noticed here is because even though it's only compiling I'm fine with making the |
this commit updates the MSRV of the `http-body` crate to 1.61. this brings the `http-body` crate into step with the MSRV of the `http-body-util` crate. in hyperium#128, the MSRV of the `http-body-util` crate was update to 1.61. however, compiling a crate in practice requires being able to parse all of the package manifests in its workspace. this means that using more recent features, like `dep:` syntax for optional dependencies included via cargo features, will not work due to the older `1.49` toolchain supported by `http-body`. see the rust reference, here: <https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies> see hyperium#140, which depends on this commit.
see: hyperium#140 (comment) this commit adds test coverage exposing the bug, and tightens the pattern used to match frames yielded by the data channel. now, when the channel is closed, a `None` will flow onwards and poll the error channel. `None` will be returned when the error channel is closed, which also indicates that the associated `Sender` has been dropped.
|
i've opened #141, which updates the MSRV, and rebased the commits in this PR to be based upon that change. i've also confirmed locally that thanks for your help reviewing this, i am very excited to get this over the finish line. 🙂 🏁 |
this commit updates the MSRV of the `http-body` crate to 1.61. this brings the `http-body` crate into step with the MSRV of the `http-body-util` crate. in #128, the MSRV of the `http-body-util` crate was update to 1.61. however, compiling a crate in practice requires being able to parse all of the package manifests in its workspace. this means that using more recent features, like `dep:` syntax for optional dependencies included via cargo features, will not work due to the older `1.49` toolchain supported by `http-body`. see the rust reference, here: <https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies> see #140, which depends on this commit.
this applies a review suggestion here: https://github.com/hyperium/http-body/pull/100/files#r1399781061 this commit refactors the channel-backed body in hyperium#100, changing the `mpsc::Receiver<E>` used to transmit an error into a `oneshot::Receiver<E>`. this should improve memory usage, and make the channel a smaller structure. in order to achieve this, some minor adjustments are made: * use pin projection, projecting pinnedness to the oneshot receiver, polling it via `core::future::Future::poll(..)` to yield a body frame. * add `Debug` bounds were needed. as an alternative, see tokio-rs/tokio#7059, which proposed a `poll_recv(..)` inherent method for a oneshot channel receiver.
this applies a review suggestion here: https://github.com/hyperium/http-body/pull/100/files#r1399780355 this commit refactors the channel-backed body in hyperium#100, changing the signature of `send_*` methods on the sender to require a mutable reference.
see: hyperium#140 (comment) this commit adds test coverage exposing the bug, and tightens the pattern used to match frames yielded by the data channel. now, when the channel is closed, a `None` will flow onwards and poll the error channel. `None` will be returned when the error channel is closed, which also indicates that the associated `Sender` has been dropped.
|
♻️ ...and now rebased on |
this branch represents a revival of #100, applying changes that were suggested in review. in particular, see 08aba95 and 4fed62f.
changes
use
sync::oneshotfor error channelthis commit refactors the channel-backed body in #100, changing the
mpsc::Receiver<E>used to transmit an error into aoneshot::Receiver<E>.this should improve memory usage, and make the channel a smaller
structure.
in order to achieve this, some minor adjustments are made:
use pin projection, projecting pinnedness to the oneshot receiver,
polling it via
core::future::Future::poll(..)to yield a body frame.add
Debugbounds were needed.use
&mut selfmethod receiversthis commit refactors the channel-backed body in #100, changing the
signature of
send_*methods on the sender to require a mutablereference.