Fix miri error

.github/workflows/ci.yml

@@ -79,3 +79,19 @@ jobs:
 
       - name: Check
         run: cargo check --target wasm32-unknown-unknown
+
+  miri:
+    name: Miri
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@nightly
+        with:
+          components: miri
+
+      - name: Test
+        run: MIRIFLAGS="-Zmiri-disable-isolation -Zmiri-ignore-leaks" cargo miri test

src/header/map.rs

@@ -2108,22 +2108,22 @@ impl<'a, T> IterMut<'a, T> {
             self.cursor = Some(Cursor::Head);
         }
 
-        let entry = unsafe { &mut (*self.map).entries[self.entry] };
+        let entry = unsafe { &(*self.map).entries[self.entry] };
 
         match self.cursor.unwrap() {
             Head => {
                 self.cursor = entry.links.map(|l| Values(l.next));
-                Some((&entry.key, &mut entry.value as *mut _))
+                Some((&entry.key, &entry.value as *const _ as *mut _))
             }
             Values(idx) => {
-                let extra = unsafe { &mut (*self.map).extra_values[idx] };
+                let extra = unsafe { &(*self.map).extra_values[idx] };
 
                 match extra.next {
                     Link::Entry(_) => self.cursor = None,
                     Link::Extra(i) => self.cursor = Some(Values(i)),
                 }
 
-                Some((&entry.key, &mut extra.value as *mut _))
+                Some((&entry.key, &extra.value as *const _ as *mut _))
             }
         }
     }

tests/header_map.rs

@@ -190,7 +190,7 @@ fn drain_entry() {
         assert_eq!(vals[1], "world2");
     }
 
-    assert_eq!(5-2+1, headers.len());
+    assert_eq!(5 - 2 + 1, headers.len());
 }
 
 #[test]
@@ -427,7 +427,6 @@ fn value_htab() {
     HeaderValue::from_str("hello\tworld").unwrap();
 }
 
-
 #[test]
 fn remove_multiple_a() {
     let mut headers = HeaderMap::new();
@@ -570,7 +569,8 @@ fn remove_entry_multi_3_others() {
 }
 
 fn remove_all_values<K>(headers: &mut HeaderMap, key: K) -> Vec<HeaderValue>
-    where K: IntoHeaderName
+where
+    K: IntoHeaderName,
 {
     match headers.entry(key) {
         Entry::Occupied(e) => e.remove_entry_mult().1.collect(),
@@ -629,10 +629,22 @@ fn remove_entry_3_others_b() {
 }
 
 fn remove_values<K>(headers: &mut HeaderMap, key: K) -> Option<HeaderValue>
-    where K: IntoHeaderName
+where
+    K: IntoHeaderName,
 {
     match headers.entry(key) {
         Entry::Occupied(e) => Some(e.remove_entry().1),
         Entry::Vacant(_) => None,
     }
 }
+
+#[test]
+fn ensure_miri_sharedreadonly_not_violated() {
+    let mut headers = HeaderMap::new();
+    headers.insert(
+        HeaderName::from_static("chunky-trailer"),
+        HeaderValue::from_static("header data"),
+    );
+
+    let _foo = &headers.iter().next();
+}