feat(lib): missing Timer will warn or panic #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
timer-warn-or-panic
branch
6 times, most recently
from
3d71ba3 to
9bdf96d
Compare
tottoto
reviewed
Nov 7, 2023
seanmonstar
force-pushed
the
timer-warn-or-panic
branch
3 times, most recently
from
0e8a1c0 to
1e2c1c5
Compare
If a default timeout is set, and no Timer, a warning will be emitted. If a timeout is configured by the user, and no Timer is set, it will panic. Closes #3393
seanmonstar
force-pushed
the
timer-warn-or-panic
branch
from
1e2c1c5 to
49f3585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a default timeout is set, and no Timer, a warning will be emitted.
If a timeout is configured by the user, and no Timer is set, it will panic.
Closes #3393