feat(lib): update to http 1.0
#3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
on-upgrade-clone
branch
2 times, most recently
from
d08cf60 to
5cbe276
Compare
Updates dependencies `http` and `http-body` to 1.0. To do so, implements `Clone` for `OnUpgrade`. BREAKING CHANGE: Upgrade to `http` 1.0.
seanmonstar
force-pushed
the
on-upgrade-clone
branch
from
5cbe276 to
1ed3056
Compare
seanmonstar
commented
Nov 15, 2023
| pub struct OnUpgrade { | ||
| rx: Option<oneshot::Receiver<crate::Result<Upgraded>>>, | ||
| rx: Option<Arc<Mutex<oneshot::Receiver<crate::Result<Upgraded>>>>>, |
There was a problem hiding this comment.
I'd love this to be optimized a bit, to not need the extra arc/mutex. But it works for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies
httpandhttp-bodyto 1.0.To do so, implements
CloneforOnUpgrade.BREAKING CHANGE: Upgrade to
http1.0.