Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md: added hyper-util to the dependencies section #3422

Closed
wants to merge 2 commits into from

Conversation

sheroz
Copy link

@sheroz sheroz commented Nov 17, 2023

There is a need to include the hyper-util crate to compile examples, otherwise, it cannot solve the dependency for TokioIo. It looks like the examples also need to be updated as they refer to an internal "../benches/support/mod.rs" for TokioIo.

sheroz and others added 2 commits November 17, 2023 17:26
There is a need to include the hyper-util crate to compile examples, otherwise, it cannot solve the dependency for TokioIo. 
It looks like the examples also need to be updated as they refer to an internal "../benches/support/mod.rs" for TokioIo
@seanmonstar
Copy link
Member

I don't think the examples can actually depend on hyper-util, since the examples are part of of the hyper crate, and hyper-util depends on hyper. So it becomes circular. The only way we could is if the examples were made separate, with their own Cargo.toml file(s), then they could depend on both hyper and hyper-util.

@seanmonstar seanmonstar closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants