Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error: borrow of moved value: header #3478

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

chrislearn
Copy link
Contributor

No description provided.

@seanmonstar
Copy link
Member

What do you mean compile error? It seemed to compile without this change.

@chrislearn
Copy link
Contributor Author

Use command cargo build --features full --features tracing or cargo build --all-features full.

I tested on windows11 stable-x86_64-pc-windows-msvc and wsl2 ubuntu stable-x86_64-unknown-linux-gnu.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean. I guess our CI doesn't check building with unstable tracing. Should fix that too. But I can verify this fixes things, thanks!

@seanmonstar seanmonstar merged commit 4df896a into hyperium:master Dec 14, 2023
20 checks passed
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
…bled (hyperium#3478)

Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants