Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(transport): Use hyper timeout feature #1497

Merged
merged 1 commit into from
May 21, 2024
Merged

chore(transport): Use hyper timeout feature #1497

merged 1 commit into from
May 21, 2024

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Sep 3, 2023 •
edited
Loading

Motivation

Simplifies implementations.

Solution

hyper has connection timeout mechanism. tonic could use it instead of hyper-timeout's connection when using hyper connector. As connect_with_connector does not assume only hyper's connection, hyper-timeout cannot be removed at this point.

@tottoto tottoto mentioned this pull request Oct 22, 2023
Open
@tottoto tottoto force-pushed the connection-timeout branch 2 times, most recently from 4792bb3 to 434bed1 Compare January 5, 2024 22:53
@tottoto tottoto force-pushed the connection-timeout branch from 23914a4 to 8cde9e1 Compare May 21, 2024 03:37
djc
djc approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@djc djc added this pull request to the merge queue May 21, 2024
Merged via the queue into hyperium:master with commit f88eb79 May 21, 2024
16 checks passed
@tottoto tottoto deleted the connection-timeout branch May 21, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @djc