Add mailbox unit tests for post dispatch #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nambrot
reviewed
Jan 19, 2024
yorhodes
added a commit
that referenced
this pull request
Feb 1, 2024
* Add pausable ism with tests * Fix paused query error case * Run CI against all PRs * Add pausable ISM to README * Build wasm * Fix scripts * Allow threshold == set size and add tests * Upload artifacts * Force * Move into makefile * Install rename * Rename properly * Update test.yaml * Fix renaming * Fix makefile indentation * Force cargo install * simple fee hook (#6) * Implement simple fee hook * Address pr comments * Fix unit tests * Make set fee only owner * Implement remaining unit tests * Fix merkle integration test use --------- Co-authored-by: nambrot <nambrot@googlemail.com> Co-authored-by: ByeongSu Hong <hong@byeongsu.dev> * Add mailbox unit tests for post dispatch (#7) * Add mailbox unit tests for post dispatch * Add test for different denoms --------- Co-authored-by: nambrot <nambrot@googlemail.com> Co-authored-by: ByeongSu Hong <hong@byeongsu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mailbox doesnt enforce default hook fees following many-things#86
This PR adds unit tests to the new mailbox behavior and ensures that required hook fees are appropriately enforced