Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update warp.ts to improve configuration logic #4723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fazleiw
Copy link

@Fazleiw Fazleiw commented Oct 22, 2024

Description

This PR refactors the process for comparing warp route configurations, transitioning from a reduce() method to a more readable for...of loop. This approach improves the organization and clarity of the code. Additionally, violations and isInvalid are now declared and initialized separately, enhancing code maintainability and making the logic easier to follow.

Drive-by changes

Added specific types for violations object to improve type safety.
Simplified logic by avoiding unnecessary nesting inside the reduce() function.

Related issues

None

Backward compatibility

Yes, the changes are backward compatible.

Testing

Changes were verified through manual testing

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 6260fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Fazleiw Fazleiw changed the title Update warp.ts refactor: Update warp.ts to improve configuration logic Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant