test: add more object utils test + remove undefined value when use with invertKeysAndValues fnc #4764
Conversation
…th invertKeysAndValues fnc
|
typescript/utils/src/objects.test.ts
Outdated
| expect(result).to.eql({ '1': 'a', '2': 'b' }); | ||
| }); | ||
|
|
||
| it('invertKeysAndValues should return an empty object if the object is empty', () => { |
There was a problem hiding this comment.
This is optional but consider nesting another describe block under the outer describe block to organize the tests by their function. E.g. a describe('invertKeysAndValues', () => block
There was a problem hiding this comment.
Thank you! Please review again
Description
Add filter
undefined/nullvalue when use with utils invertKeysAndValues functionAdd more test at
objects.test.tsDrive-by changes
return Object.fromEntries( Object.entries(data) + .filter(([_, value]) => value !== undefined && value !== null) // Filter out undefined and null values .map(([key, value]) => [value, key]), );Related issues
None
Backward compatibility
Currently, nowhere call this invertKeysAndValues func
Testing
Yes, more tests.