-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: core deploy apply admin proxy ownership fixes #4767
Open
xeno097
wants to merge
14
commits into
xeno/warp-deploy-apply-ownership-fixes
Choose a base branch
from
xeno/core-deploy-apply-admin-proxy-ownership-fixes
base: xeno/warp-deploy-apply-ownership-fixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: core deploy apply admin proxy ownership fixes #4767
xeno097
wants to merge
14
commits into
xeno/warp-deploy-apply-ownership-fixes
from
xeno/core-deploy-apply-admin-proxy-ownership-fixes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to core init command
…nfig defines owners fro the mailbox proxy admin adn ica router and use those values intead of the signer
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
…r the mailbox contract
…admin proxy ownership code
…ly for core command testing
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
xeno097
requested review from
tkporter,
paulbalaji,
Mo-Hussain,
jmrossy,
yorhodes and
ltyu
as code owners
October 25, 2024 21:41
🦋 Changeset detectedLatest commit: d58f6a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
hyperlane core init
,hyperlane core deploy
andhyperlane core apply
commands to allow a user to change ownership of the mailbox ProxyAdmin contract by setting a value in the config.Drive-by changes
randomAddress
test util implementations across thesdk
, 'infra' andcli
packageanvil1
to therun-e2e-test.sh
script to testhyperlane core
commands in isolationproxyAdminOwnershipUpdateTxs
to deduplicate proxy admin ownership tx data generationRelated issues
Backward compatibility
Testing
NOTE: