Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core deploy apply admin proxy ownership fixes #4767

Open
wants to merge 14 commits into
base: xeno/warp-deploy-apply-ownership-fixes
Choose a base branch
from

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Oct 25, 2024

Description

This PR updates the hyperlane core init, hyperlane core deploy and hyperlane core apply commands to allow a user to change ownership of the mailbox ProxyAdmin contract by setting a value in the config.

Drive-by changes

  • deduped randomAddress test util implementations across the sdk, 'infra' and cli package
  • added anvil1 to the run-e2e-test.sh script to test hyperlane core commands in isolation
  • implemented the proxyAdminOwnershipUpdateTxs to deduplicate proxy admin ownership tx data generation

Related issues

Backward compatibility

  • Yes

Testing

  • Manual
  • e2e

NOTE:

…nfig defines owners fro the mailbox proxy admin adn ica router and use those values intead of the signer
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: d58f6a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/infra Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant