This repository was archived by the owner on Dec 2, 2021. It is now read-only.
Run CI with go 1.13.15#37
Open
swetharepakula wants to merge 2 commits intohyperledger-archives:mainfrom
Open
Conversation
swetharepakula
force-pushed
the
upgrade-go-version
branch
8 times, most recently
from
d6f8e66 to
516b780
Compare
- use fabric `release-1.4` branch to pull in fix for nexus repo change required to build fabric components Signed-off-by: Swetha Repakula <swetha.repakula@gmail.com>
swetharepakula
force-pushed
the
upgrade-go-version
branch
2 times, most recently
from
b19d403 to
ccc26e2
Compare
Signed-off-by: Swetha Repakula <swetha.repakula@gmail.com>
swetharepakula
force-pushed
the
upgrade-go-version
branch
from
ccc26e2 to
4ec02be
Compare
Contributor
|
Definitely confusing for the integration tests. I see but above that it prints out that image Rumor was it worked locally? |
MHBauer
previously approved these changes
Mar 22, 2021
Contributor
MHBauer
left a comment
MHBauer
left a comment
There was a problem hiding this comment.
Pretty much fine. Nits only if you want to address.
Not sure how to get the integration working from a quick look.
| By("setting up the channel") | ||
| network.CreateAndJoinChannel(orderer, channelName) | ||
| network.UpdateChannelAnchors(orderer, channelName) | ||
| network.EventuallyTimeout = 2 * time.Minute |
Contributor
There was a problem hiding this comment.
bigger timeouts? Things going slower?
| echo "Please switch Fabric Repository to tag v1.4.0 before running these tests" | ||
| FABRIC_VERSION=$(git -C ${FABRIC_DIR} rev-parse --abbrev-ref HEAD) | ||
| if [[ ${FABRIC_VERSION} != "release-1.4" ]]; then | ||
| echo "Please switch Fabric Repository to release v1.4.0 before running these tests, it currently is on ${FABRIC_VERSION}" |
Contributor
There was a problem hiding this comment.
Does this have to match exactly the branch name?
If so, the echo Error message should update to say "branch relaese-1.4".
| - main | ||
| pr: | ||
| - master | ||
| - main |
Contributor
There was a problem hiding this comment.
I would suggest pulling this out into a spearate pr, but we're probably in a broken state until it gets done.
Add a Comment in the commit message.
Need a follow up issue, for revising the documentation where the default branch name shows up.
Contributor
|
Oh, I see, this is a stack on #38 |
MHBauer
reviewed
Mar 22, 2021
| make ccenv CHAINTOOL_URL='https://hyperledger.jfrog.io/hyperledger/fabric-maven/org/hyperledger/fabric-chaintool/$(CHAINTOOL_RELEASE)/fabric-chaintool-$(CHAINTOOL_RELEASE).jar' | ||
| popd | ||
|
|
||
| echo "$(docker images)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.