Fix lint introduced by Rust 1.71.0

libsawtooth/src/families/smallbank/workload/playlist.rs

@@ -593,7 +593,7 @@ impl<'a> FmtWriter<'a> {
 impl<'a> fmt::Write for FmtWriter<'a> {
     fn write_str(&mut self, s: &str) -> Result<(), fmt::Error> {
         let w = &mut *self.writer;
-        w.write_all(s.as_bytes()).map_err(|_| fmt::Error::default())
+        w.write_all(s.as_bytes()).map_err(|_| fmt::Error)
     }
 }
 

libsawtooth/src/journal/publisher/mod.rs

@@ -459,7 +459,7 @@ impl BlockPublisher {
     ///   * The summary of the batches
     fn complete_candidate_block(
         &self,
-        mut candidate_block: &mut CandidateBlock,
+        candidate_block: &mut CandidateBlock,
     ) -> Result<(), BlockPublisherError> {
         // Check if candidate block is already completed
         if candidate_block.summary.is_some() {

libsawtooth/tests/state/merkle/mod.rs

@@ -333,7 +333,7 @@ where
             key: key_hash.to_string(),
             value: "2.0".as_bytes().to_vec(),
         });
-        values.insert(key_hash.clone().to_string(), "2.0".to_string());
+        values.insert(key_hash.to_string(), "2.0".to_string());
     }
 
     // The first item below(e55420...89b9) shares a common prefix
@@ -449,10 +449,10 @@ fn test_merkle_trie_update_same_address_space_with_no_children<M>(
     // Perform some updates on the lower keys
     for &(_, ref key_hash) in key_hash_to_be_inserted.iter() {
         state_changes.push(StateChange::Set {
-            key: key_hash.clone().to_string(),
+            key: key_hash.to_string(),
             value: "2.0".as_bytes().to_vec(),
         });
-        values.insert(key_hash.clone().to_string(), "2.0".to_string());
+        values.insert(key_hash.to_string(), "2.0".to_string());
     }
 
     // The first item below(e55420...89b9) shares a common prefix