This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Move transact::protocol::* to protocol::* #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an incremental step toward integrating transact fully into libsawtooth. This removes the transact feature guard on these protocol structs, with the exception of receipt; receipt needs further refactoring so that it does not reference non-protocol code. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
vaporos
requested review from
agunde406,
cianx,
dcmiddle,
isabeltomb,
jsmitchell,
peterschwarz,
rberg2 and
rbuysse
as code owners
agunde406
approved these changes
Aug 9, 2023
peterschwarz
approved these changes
Aug 9, 2023
rbuysse
approved these changes
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental step toward integrating transact fully into libsawtooth. This removes the transact feature guard on these protocol structs, with the exception of receipt; receipt needs further refactoring so that it does not reference non-protocol code.