Skip to content

Commit

Permalink
feat(cactus-core): add ConnectRPC service interface and type guard
Browse files Browse the repository at this point in the history
Define the types and type guard needed for the API server to be able to
recognize plugins that have implemented a ConnectRPC interface for their
operations.

Also, these types will be used by the plugins themselves to mark the
implementations as valid for ConnectRPC usage.

ConnectRPC is very similar to gRPC but has some nice features in addition
to it such as the HTTP 2 and HTTP 1.1 proxying through express and
fastify HTTP server instances.

For further details see this link:
https://connectrpc.com/

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Apr 4, 2024
1 parent 5762dad commit 9e83087
Show file tree
Hide file tree
Showing 5 changed files with 95 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,14 @@
"clsx",
"commenceack",
"configtx",
"connectrpc",
"Corda",
"Cordapp",
"couchdb",
"COUCHDBADDRESS",
"COUCHDBCONFIG",
"Creds",
"Crpc",
"data",
"davecgh",
"dclm",
Expand All @@ -59,6 +61,7 @@
"escc",
"execa",
"faio",
"fastify",
"fidm",
"flowdb",
"fsouza",
Expand Down
2 changes: 2 additions & 0 deletions packages/cactus-core-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@
"axios": "1.6.0"
},
"devDependencies": {
"@bufbuild/protobuf": "1.8.0",
"@connectrpc/connect": "1.4.0",
"@grpc/grpc-js": "1.10.3",
"@grpc/proto-loader": "0.7.8",
"@types/express": "4.17.19",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
import type { ServiceType } from "@bufbuild/protobuf";
import type { ServiceImpl } from "@connectrpc/connect";
import type { UniversalHandlerOptions } from "@connectrpc/connect/protocol";

/**
* Implementers of this interface are responsible for providing a Crpc service
* that can be dynamically registered at runtime by the API server.
*
* It describes what methods a class (plugin) needs to implement
* in order to be able to operate as a Cacti Crpc service (e.g. expose its
* functionality through Crpc not just HTTP or SocketIO)
*
* @see {IPluginWebService}
* @see {IPluginGrpcService}
* @see {ApiServer}
*/
export interface IPluginCrpcService {
/**
* Used by the API server and/or automated test cases when hooking up this
* plugin instance into a crpc Server object.
*
* The returned pair of service
* definition and implementation objects are passed in to the `.addService()`
* method of the `Server` object of the `@connectrpc/connect` library.
*
* @see {ServiceDefinition}
* @see {ServiceType}
* @see {ICrpcSvcRegistration}
*/
createCrpcSvcRegistrations(
opts: unknown,
): Promise<Array<ICrpcSvcRegistration<ServiceType>>>;
}

/**
* A wrapper object that contains both the the definition and the implementation
* objects of a crpc service that a plugin can implement to expose it's functionality
* over crpc.
*
* @see {IPluginGrpcService}
* @see {IGrpcSvcDefAndImplPair}
*/
export interface ICrpcSvcRegistration<T extends ServiceType> {
readonly definition: T;
readonly implementation: Partial<ServiceImpl<T>>;
readonly serviceName: string;
readonly options?: Partial<UniversalHandlerOptions>;
}

/**
* Custom (user-defined) Typescript type-guard that verifies at runtime whether
* `x` is an implementation of {IPluginCrpcService} or not.
*
* @param x Literally any object or value that you'd want to verify for having
* the right method(s) implemented in-order to qualify as an implementer of the
* {IPluginCrpcService} interface.
*
* The {ApiServer} uses this to filter the total list of plugins down to the ones
* that have crpc services of their own and then hook those up at runtime.
*
* @returns `true` if `x` does implement {IPluginCrpcService} `false` otherwise.
*/
export function isIPluginCrpcService(x: unknown): x is IPluginCrpcService {
return (
!!x &&
typeof (x as IPluginCrpcService).createCrpcSvcRegistrations === "function"
);
}
4 changes: 4 additions & 0 deletions packages/cactus-core-api/src/main/typescript/public-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,7 @@ export { ISendRequestResultV1 } from "./plugin/ledger-connector/i-send-request-r
export { IPluginGrpcService } from "./plugin/grpc-service/i-plugin-grpc-service";
export { IGrpcSvcDefAndImplPair } from "./plugin/grpc-service/i-plugin-grpc-service";
export { isIPluginGrpcService } from "./plugin/grpc-service/i-plugin-grpc-service";

export { ICrpcSvcRegistration } from "./plugin/crpc-service/i-plugin-crpc-service";
export { IPluginCrpcService } from "./plugin/crpc-service/i-plugin-crpc-service";
export { isIPluginCrpcService } from "./plugin/crpc-service/i-plugin-crpc-service";
18 changes: 18 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4341,6 +4341,13 @@ __metadata:
languageName: node
linkType: hard

"@bufbuild/protobuf@npm:1.8.0":
version: 1.8.0
resolution: "@bufbuild/protobuf@npm:1.8.0"
checksum: 10/f91d60ff1609c023466500e99312d2e92ac09c163d615c315fa25d9e50f1e9b76a3a9cac776786a3dd5c5065bb7061bf29388587e2a1d27306f68ed98e57a892
languageName: node
linkType: hard

"@chainsafe/as-sha256@npm:^0.3.1":
version: 0.3.1
resolution: "@chainsafe/as-sha256@npm:0.3.1"
Expand Down Expand Up @@ -4607,6 +4614,15 @@ __metadata:
languageName: node
linkType: hard

"@connectrpc/connect@npm:1.4.0":
version: 1.4.0
resolution: "@connectrpc/connect@npm:1.4.0"
peerDependencies:
"@bufbuild/protobuf": ^1.4.2
checksum: 10/5e84fbba544f7e52533bdd0058caaa6d5c89903f522fbd9551c6bad0cd2fea2d3f14c7396696609d1787a5e2018054dd53db40b2d08c55975ff81334074eeeae
languageName: node
linkType: hard

"@cspell/cspell-bundled-dicts@npm:^5.21.2":
version: 5.21.2
resolution: "@cspell/cspell-bundled-dicts@npm:5.21.2"
Expand Down Expand Up @@ -7672,6 +7688,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "@hyperledger/cactus-core-api@workspace:packages/cactus-core-api"
dependencies:
"@bufbuild/protobuf": "npm:1.8.0"
"@connectrpc/connect": "npm:1.4.0"
"@grpc/grpc-js": "npm:1.10.3"
"@grpc/proto-loader": "npm:0.7.8"
"@hyperledger/cactus-common": "npm:2.0.0-alpha.2"
Expand Down

0 comments on commit 9e83087

Please sign in to comment.