fix(plugin-odap-hermes): fix duplicate enum values of OdapMessageType #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Jul 18, 2023
petermetz
force-pushed
the
petermetz/issue2553
branch
from
6e02703
to
2308dcd
Compare
auto-merge was automatically disabled
July 20, 2023 03:18
Base branch was modified
CommitFinalResponse and CommitPreparationResponse were accidentally having the same enum value, fixed it by providing the correct enum value (as per the specs) for CommitFinalResponse. Links: 1. https://datatracker.ietf.org/doc/bofreq-hardjono-secure-asset-transfer-protocol/ 2. https://www.ietf.org/archive/id/draft-hargreaves-odap-03.txt Fixes hyperledger-cacti#2553 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2553
branch
from
2308dcd
to
0c8aa20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommitFinalResponse and CommitPreparationResponse
were accidentally having the same enum value, fixed it by
providing the correct enum value (as per the specs) for
CommitFinalResponse.
Links:
Fixes #2553
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com