Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-plugin-ledger-connector-ethereum): update web3js to 4.X #2581

Merged

Commits on Sep 29, 2023

  1. feat(cactus-plugin-ledger-connector-ethereum): update web3js to 4.X

    - Update web3js packages from 1.10 to 4.0.3 in `cactus-plugin-ledger-connector-ethereum` and
        `cactus-test-plugin-ledger-connector-ethereum`. This allows interacting
        with most recent geth nodes.
    - Refactor all ethereum tests. Most of the test cases were duplicated multiple times
        (between different quorum ledger versions test and deployment methods). I've removed all this
        duplication while maintaining similar level of test coverage.
        New tests use Geth test ledger instead of Quorum one.
    - Add web3js type conversions methods to minimize impact of poor dynamic typing
        in this early release of 4.X.
    - Update API. In 4.X all numeric responses has been converted to BigNum.
        To keep up with this some fields has been changed to string instead of number when necessary.
        Add some missing fields as well.
    - Add `estimateMaxFeePerGas` method for estimating current transaction cost.
    - Fix invalid `runTransact` response type.
    - Add test script for checking integration with Alchemy that must be executed manually
        (it's excluded from CI at the moment) - `geth-alchemy-integration-manual-check.test`.
        Instructions on how to run it has been added to package README.
    
    Closes: hyperledger-cacti#2580
    
    Depends on hyperledger-cacti#2535
    Depends on hyperledger-cacti#2578
    
    Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    
    Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
    Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    outSH authored and petermetz committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    39408c9 View commit details
    Browse the repository at this point in the history