-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples/supply-chain): fix yarn --no-lockfile #2983
docs(examples/supply-chain): fix yarn --no-lockfile #2983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez It crash-loops on my machine with the Fabric AIO container never coming online (attached logs).
Could you please also post your complete log output of the yarn start:example-supply-chain
that shows that the app comes online successfully? Diffing that against my log file should tell us what is the difference (hopefully)
2024-01-20-cacti-supply-chain-example-not-working.log
@petermetz Yes, I have also experienced that scenario. And it is like that for the whole day for me and then when I try it the next day it is working and the Fabric AIO comes online and the supply chain application runs. Maybe this can help, here are the steps that I do before running the supply chain app
and here below is the logs when the supply chain app is successfully online |
c9cf0f0
to
53a0a15
Compare
53a0a15
to
f6e9d62
Compare
@aldousalvarez Got it, thank you! It's not ideal, but a small step forward is not a bad move so let's merge this and then I'll try to work on fixing the supply chain app so that it actually works with the documented steps. |
Primary Changes --------------- 1. Removed examples/supply-chain-app/package.json and moved the other files to cactus-example-supply -chain-backend 2. Updated the docs to match the updated path of the supply-chain-app files to cactus-example-supply- chain-backend and the new steps on how run the latest supply chain app 3. Updated the code responses in connector-fabric from null to (0) based on the logs and responses while running the application. 4. Added a parse.int for shelfCount in bookshelf- converter because it requires a number but instead the value becomes a string before it is submitted. Fixes hyperledger-cacti#2721 Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
Head branch was pushed to by a user without write access
f6e9d62
to
10ec48a
Compare
Primary Changes
Fixes #2721
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.