feat(ethereum-connector): support block monitoring with http only connection #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
…nection
- Update web3.js to 4.4 (I was hoping to use requested by me `safeDisconnect`
method, but it seem to be still unavailable in this version)
- Support monitoring without websocket ethereum node access by using
http polling method. Method is chosed automatically during runtime, based on
supplied ethereum node URL.
- Refactored `WatchBlocksV1Endpoint` into base class and child classes that
implement monitoring strategies. `WatchBlocksV1Endpoint` is now instantiated
with factory method. This will allow easier addition of
new strategies in the future.
- Add monitoring tests to ethereum connector pacakge, remove overlaping tests
from verifier-integration-with-ethereum-connector.test.
Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH
force-pushed
the
geth_block_polling
branch
from
fe98302
to
4f0acfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safeDisconnectmethod, but it seem to be still unavailable in this version)WatchBlocksV1Endpointinto base class and child classes that implement monitoring strategies.WatchBlocksV1Endpointis now instantiated with factory method. This will allow easier addition of new strategies in the future.Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.