-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fabric-connector): add getChainInfo, improve getBlock output #3298
feat(fabric-connector): add getChainInfo, improve getBlock output #3298
Conversation
...ctor-fabric/src/test/typescript/integration/fabric-v2-2-x/query-system-chain-methods.test.ts
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH LGTM, thank you!
07e3bb6
to
3ac2cbb
Compare
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
As per @petermetz suggestion in https://github.com/hyperledger/cacti/pull/3308#discussion_r1637090342, I've rebased with main and changed the following:
|
3ac2cbb
to
2e1dada
Compare
@outSH Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work
- Add new method `getChainInfo` for quering chain information from qscc. - Add `GetChainInfoEndpointV1` to allow calling `getChainInfo` remotely. - Refactor `getBlock` so it can return same custom block formats as `WatchBlocks`. Default remains the same (full decode block). BREAKING CHANGE: It accepts `type` instead of `skipDecode` flag. - Move common block formatting logic to `cacti-block-formatters.ts`. - Add tests for new features. Move test common to quering `qscc` to single file to increase CI speed. Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
2e1dada
to
9b2d4a8
Compare
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on hyperledger-cacti#3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
- Rewrite fabric persistence plugin to match persistence ethereum plugin methods and behavior. - Change DB schema for persistence. - Add tests and sample data to the new plugin. Add them to project CI. Depends on #3298 Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
getChainInfo
for quering chain information from qscc.GetChainInfoEndpointV1
to allow callinggetChainInfo
remotely.getBlock
so it can return same custom block formats asWatchBlocks
. Default remains the same (full decode block). BREAKING CHANGE: It acceptstype
instead ofskipDecode
flag.cacti-block-formatters.ts
.qscc
to single file to increase CI speed.Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.