Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ledger-browser): rewrite fabric application #3320

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat(ledger-browser): rewrite fabric application #3320

merged 1 commit into from
Jul 24, 2024

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jun 13, 2024 •
edited
Loading

  • Rewrite fabric app using MUI components and new database schema.
  • Improve UITableListing to support clickable tables.
  • The new app supports the following views:
    • Dashboard: Shows summary of blocks and transaction recorded in database.
    • Block list: Full list of blocks
    • Transaction list: Full list of transactions
    • Transaction details: Page that shows full transaction information,
      transaction actions (method calls) and endorsements.

Depends on https://github.com/hyperledger/cacti/pull/3308
Depends on https://github.com/hyperledger/cacti/pull/3279

Signed-off-by: Michal Bajer michal.bajer@fujitsu.com
Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

outSH added a commit to outSH/cactus that referenced this pull request Jun 20, 2024
@outSH
feat(ledger-browser): refactor home page
45ab083 
- Remove status apps, its functionality has been moved to the home page.
- Add status components for persistence apps.
- Add home page that contains cards for each configured app. Clicking on it
  naviagtes to specific app, clicking on Status button shows status component.
- Remove app drawer, replace it with a button that navigates to root path
  (i.e. the home app, navigation between apps is handled here).
- Remove all the remaining dead and legacy code, apply small structure upgrades.
- Since this PR removes all old code, and all the current code was written by
  me and Tomasz, I've also removed previous inactive package contributors.

Depends on hyperledger-cacti#3320

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH mentioned this pull request Jun 20, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

  • hyperledger/cacti#3308
  • hyperledger/cacti#3279
    By Dependent Issues (🤖). Happy coding!

izuru0
izuru0 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outSH outSH enabled auto-merge (rebase) July 22, 2024 09:18
@outSH @petermetz
feat(ledger-browser): rewrite fabric application
dc0e2bc 
- Rewrite fabric app using MUI components and new database schema.
- Improve `UITableListing` to support clickable tables.
- The new app supports the following views:
  - Dashboard: Shows summary of blocks and transaction recorded in database.
  - Block list: Full list of blocks
  - Transaction list: Full list of transactions
  - Transaction details: Page that shows full transaction information,
    transaction actions (method calls) and endorsements.

Depends on hyperledger-cacti#3308
Depends on hyperledger-cacti#3279

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH merged commit ecf074c into hyperledger-cacti:main Jul 24, 2024
142 of 144 checks passed
outSH added a commit to outSH/cactus that referenced this pull request Jul 25, 2024
@outSH
feat(ledger-browser): refactor home page
19af4b0 
- Remove status apps, its functionality has been moved to the home page.
- Add status components for persistence apps.
- Add home page that contains cards for each configured app. Clicking on it
  naviagtes to specific app, clicking on Status button shows status component.
- Remove app drawer, replace it with a button that navigates to root path
  (i.e. the home app, navigation between apps is handled here).
- Remove all the remaining dead and legacy code, apply small structure upgrades.
- Since this PR removes all old code, and all the current code was written by
  me and Tomasz, I've also removed previous inactive package contributors.

Depends on hyperledger-cacti#3320

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
petermetz pushed a commit to outSH/cactus that referenced this pull request Aug 1, 2024
@outSH @petermetz
feat(ledger-browser): refactor home page
4632305 
- Remove status apps, its functionality has been moved to the home page.
- Add status components for persistence apps.
- Add home page that contains cards for each configured app. Clicking on it
  naviagtes to specific app, clicking on Status button shows status component.
- Remove app drawer, replace it with a button that navigates to root path
  (i.e. the home app, navigation between apps is handled here).
- Remove all the remaining dead and legacy code, apply small structure upgrades.
- Since this PR removes all old code, and all the current code was written by
  me and Tomasz, I've also removed previous inactive package contributors.

Depends on hyperledger-cacti#3320

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this pull request Aug 6, 2024
@outSH
feat(ledger-browser): refactor home page
9c99b92 
- Remove status apps, its functionality has been moved to the home page.
- Add status components for persistence apps.
- Add home page that contains cards for each configured app. Clicking on it
  naviagtes to specific app, clicking on Status button shows status component.
- Remove app drawer, replace it with a button that navigates to root path
  (i.e. the home app, navigation between apps is handled here).
- Remove all the remaining dead and legacy code, apply small structure upgrades.
- Since this PR removes all old code, and all the current code was written by
  me and Tomasz, I've also removed previous inactive package contributors.

Depends on hyperledger-cacti#3320

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit to outSH/cactus that referenced this pull request Aug 7, 2024
@outSH
feat(ledger-browser): refactor home page
5bab29c 
- Remove status apps, its functionality has been moved to the home page.
- Add status components for persistence apps.
- Add home page that contains cards for each configured app. Clicking on it
  naviagtes to specific app, clicking on Status button shows status component.
- Remove app drawer, replace it with a button that navigates to root path
  (i.e. the home app, navigation between apps is handled here).
- Remove all the remaining dead and legacy code, apply small structure upgrades.
- Since this PR removes all old code, and all the current code was written by
  me and Tomasz, I've also removed previous inactive package contributors.

Depends on hyperledger-cacti#3320

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit that referenced this pull request Aug 7, 2024
@outSH
feat(ledger-browser): refactor home page
500ac9b 
- Remove status apps, its functionality has been moved to the home page.
- Add status components for persistence apps.
- Add home page that contains cards for each configured app. Clicking on it
  naviagtes to specific app, clicking on Status button shows status component.
- Remove app drawer, replace it with a button that navigates to root path
  (i.e. the home app, navigation between apps is handled here).
- Remove all the remaining dead and legacy code, apply small structure upgrades.
- Since this PR removes all old code, and all the current code was written by
  me and Tomasz, I've also removed previous inactive package contributors.

Depends on #3320

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz petermetz approved these changes

@izuru0 izuru0 izuru0 approved these changes

@takeutak takeutak Awaiting requested review from takeutak

@jagpreetsinghsasan jagpreetsinghsasan Awaiting requested review from jagpreetsinghsasan jagpreetsinghsasan is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@outSH @petermetz @izuru0