Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump uuid@10.0.0 fs-extra@11.2.0 @bufbuild/protobuf@1.10.0 #3385

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Jul 6, 2024

BREAKING CHANGE: Renamed classes to fix typos in their name: PluginFactoryPersistanceFabric
This is being done in this pull request because for some reason (that I still don't understand)
the spell checker started failing on these only in the context of this pull request.
The typos were present on the main branch already somehow having passed spellchecking earlier
and every other time since then.

And also

  • prom-clien@15.1.3
  • del-cli@5.1.0
  • cspell@8.10.4
  • del-cli@5.1.0

Quality of life improvements and also hoping to get rid of a few of the
vulnerable dependency versions we have in the codebase according to
dependabot.

More similar changes are coming in with further upgrades but I want to
avoid making bigger changes in one go so that it's easier to hunt down
bugs later if something only gets discovered after we've merged a bunch
of these.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

BREAKING CHANGE: Renamed classes to fix typos in their name: `PluginFactoryPersistanceFabric`
This is being done in this pull request because for some reason (that I still don't understand)
the spell checker started failing on these only in the context of this pull request.
The typos were present on the main branch already somehow having passed spellchecking earlier
and every other time since then.

And also
- prom-clien@15.1.3
- del-cli@5.1.0
- cspell@8.10.4
- del-cli@5.1.0

Quality of life improvements and also hoping to get rid of a few of the
vulnerable dependency versions we have in the codebase according to
dependabot.

More similar changes are coming in with further upgrades but I want to
avoid making bigger changes in one go so that it's easier to hunt down
bugs later if something only gets discovered after we've merged a bunch
of these.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the build-deps-upgrade-uuid-cspell-bufbuild branch from a31e00f to 7b43791 Compare July 7, 2024 23:50
@petermetz
Copy link
Contributor Author

petermetz commented Jul 7, 2024

@izuru0 @outSH Please make sure to review this one because I had to add a breaking change to the Fabric persistence plugin. More details in the commit message.
Note to self: Do not merge until at least one person from the two mentioned above OK'd it.

@outSH
Copy link
Contributor

outSH commented Jul 8, 2024

@petermetz Sure, no problem, done similar changes in #3308

@petermetz petermetz merged commit 9970352 into hyperledger-cacti:main Jul 8, 2024
138 of 152 checks passed
@petermetz petermetz deleted the build-deps-upgrade-uuid-cspell-bufbuild branch July 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants