Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test-tooling): use of hardcoded password #3428

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(test-tooling): use of hardcoded password #3428

merged 1 commit into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. fix(test-tooling): use of hardcoded password 

    Primary Changes
----------------
1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function
defined in openethereum-test-ledger.ts. It was previously optional.
2. Updated line 236 in openethereum-test-ledger.ts so the default password argument to the
newEthPersonalAccount function is not hardcoded.

Fixes hyperledger-cacti#2766

Signed-off-by: ashnashahgrover <as19@williams.edu>
    @ashnashahgrover @petermetz
    ashnashahgrover authored and petermetz committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e8c01fa View commit details
    Browse the repository at this point in the history