Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aries): refactor jest test negative test cases #3474

Merged

Conversation

ashnashahgrover
Copy link
Contributor

@ashnashahgrover ashnashahgrover commented Aug 12, 2024

Commit to be reviewed

test(aries): refactor jest test negative test cases

Primary Changes
----------------
1. Refactored all the negative test case exception assertions for
cactus-plugin-ledger-connector-aries. Removed try-catch blocks,
replaced with declarations through jest-extended's own API.

Fixes #3473

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@jagpreetsinghsasan
Copy link
Contributor

@ashnashahgrover the pr-commit parity checker is failing because your PR message contains a special character after Primary Changes
This is how it is getting rendered in my mail
image

I then updated your PR message and now when I run it, it still fails as there is diff (very minute)
image

I have updated it again and it still fails and now this is something which my upcoming patch for the CI test will fix. (Please do not spend any time on fixing the Commit Parity check)

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Please run yarn run lint to format sources and fix the lint CI error

@ashnashahgrover
Copy link
Contributor Author

LGTM, thank you!

Please run yarn run lint to format sources and fix the lint CI error

Done.

@outSH outSH enabled auto-merge (rebase) August 22, 2024 09:47
Primary Changes
----------------
1. Refactored all the negative test case exception assertions for
cactus-plugin-ledger-connector-aries. Removed try-catch blocks,
replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3473

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@outSH outSH merged commit bf35762 into hyperledger-cacti:main Aug 22, 2024
144 of 145 checks passed
@petermetz petermetz deleted the ashnashahgrover/issue3473 branch August 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(aries): refactor jest test negative test cases
5 participants