-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(connector-besu): migrate get-past-logs-endpoint to Jest #3608
base: main
Are you sure you want to change the base?
test(connector-besu): migrate get-past-logs-endpoint to Jest #3608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshitha1020 Thank you! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akshitha1020 Please fix the lint CI check that failed with the message pasted below:
Error: yarn lint script produced version control side-effects: source files have been changed by it that are otherwise are under version control. This means (99% of the time) that you need to run the yarn lint script locally and then include the changes it makes in your own commit when submitting your pull request.
(you can run the linter locally by doing yarn lint
on the command line)
Hi @petermetz, tried running |
@Akshitha1020 after running In this PR, the lint failed here |
Also, to fix the PR - Commit Parity failing check, please update your commit message to this (I have updated the PR Desciption accordingly)
|
8508fd6
to
cd3b61a
Compare
Hi @jagpreetsinghsasan, I have done the changes as you mentioned, please re-review and let me know. |
@Akshitha1020 all good from my past review comment. There is a merge conflict, can you please resolve that as well? |
@Akshitha1020 If you are end up struggling with the git operations needed to resolve the merge conflicts just let me know and I can help (You'll just need to invite me as a collaborator to your fork so that I have permission to push to your PR branch directly) |
51cbdf6
to
f93bee4
Compare
Hi @petermetz, resolved the conflicts but on squashing the commits again it is showing conflicts. I have invited you to be a collaborator to my fork, please accept. |
@Akshitha1020 Okay, no worries! I accepted the invite just now, I'll push the changes soon. |
Primary Changes ------------------ 1. Updated the migrate get-past-logs-endpoint test to use Jest 2. Updated the ci.yaml TAPE_TEST_PATTERN to incorporate the same Fixes hyperledger-cacti#3505 Co-authored-by: Peter Somogyvari <peter.somogyvari@accenture.com> Signed-off-by: Akshitha1020 <159411458+Akshitha1020@users.noreply.github.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
f93bee4
to
de6d608
Compare
Commit to be reviewed
test(connector-besu): migrate get-past-logs-endpoint to Jest
Fixes #3505
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.