Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bungee-hermes): add BUNGEE package #3640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RafaelAPB
Copy link
Contributor

@RafaelAPB RafaelAPB commented Nov 15, 2024

BUNGEE is an implementation of a view generator https://dl.acm.org/doi/10.1145/3643689

Depends on #3638 and #3639;: #3642, #3643 #3644

Authored-by: Eduardo Vasques eduardovasques10@tecnico.ulisboa.pt
Co-authored-by: Rafael Belchior rafael.belchior@tecnico.ulisboa.pt
Signed-off-by: Rafael Belchior rafael.belchior@tecnico.ulisboa.pt

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

BUNGEE is an implementation of a view generator https://dl.acm.org/doi/10.1145/3643689

Authored-by: Eduardo Vasques <eduardovasques10@tecnico.ulisboa.pt>
Co-authored-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt>
Signed-off-by: Rafael Belchior <rafael.belchior@tecnico.ulisboa.pt>
Copy link

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant