Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Npm to Yarn #647

Closed
wants to merge 5 commits into from

Merge branch 'hyperledger:main' into yarn

ed167b0
Select commit
Loading
Failed to load commit list.
Closed

Update Npm to Yarn #647

Merge branch 'hyperledger:main' into yarn
ed167b0
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Oct 31, 2024 in 0s

Check failed

There are 2 commits incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🔴 9aea896 update npm to yarn Sign-off not found
🟢 b28927e Merge branch 'main' of https://github.com/link1697... Skipped: sign-off not required in merge commit
🟢 5f5ebe8 Merge branch 'main' of https://github.com/link1697... Skipped: sign-off not required in merge commit
🔴 b3b14ef update postgres to v12 Sign-off not found
🟢 ed167b0 Merge branch 'hyperledger:main' into yarn Skipped: sign-off not required in merge commit

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~5 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin yarn