Skip to content

Conversation

@goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Oct 4, 2025

Description:

This is quite extensive PR since it makes the DIDDocument codable.

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@goncalo-frade-iohk goncalo-frade-iohk requested a review from a team as a code owner October 4, 2025 11:38
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/did-resolver-http branch 2 times, most recently from 87fae95 to 0b1e503 Compare October 4, 2025 12:34
}

public struct GitHubResolverURLBuilder: DIDDocumentUrlBuilder {
let baseURL = "https://raw.githubusercontent.com/blockfrost/prism-vdr/refs/heads/main/mainnet/diddoc/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goncalo-frade-iohk, could you clarify with @FabioPinheiro if the blockfrost fork is properly maintained.
Probably, it makes sense to fork the repo under IOG or Hyperledger orgs, so we can properly maintain it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of blockfrost/prism-vdr I'm using my FabioPinheiro/prism-vdr repo now since it's easy to maintain.
I would love to move that repository to Identus or IOHK @yshyn-iohk.

Copy link
Contributor

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/did-resolver-http branch from 0b1e503 to 3efdb09 Compare October 27, 2025 18:27
This is quite extensive PR since it makes the DIDDocument codable.

Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/did-resolver-http branch from 3efdb09 to 3fec8b3 Compare October 27, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants