This repository has been archived by the owner on Jun 8, 2020. It is now read-only.
Primality testing #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lovesh <lovesh.harchandani@evernym.com>
Signed-off-by: Lovesh <lovesh.harchandani@evernym.com>
Signed-off-by: Lovesh <lovesh.harchandani@evernym.com>
vimmerru
reviewed
Feb 8, 2018
| use std::slice; | ||
|
|
||
| #[no_mangle] | ||
| pub extern fn indy_crypto_primality_check(big_endian_number: *const u8, |
There was a problem hiding this comment.
I want to ask for some changes to follow design and code structure. I believe we need to add is_prime method to BN entity instead of providing static non-entity related call. Now you provides different Rust API and FFI API.
It will allow to expose big nums in more clean and re-usable way. FFI API can look like this:
let bn = null;
ind_crypto_bn_new(bytes, &bn)
let is_prime = indy_crypto_bn_is_prime(bn)
indy_crypto_free(bn)
it will later allow to expose complete big nums API
There was a problem hiding this comment.
The same needs to be added to python wrapper. Just follow the same entity model as Rust API.
There was a problem hiding this comment.
Add is_prime to which BN entity?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFI wrapper for is_prime method, update to the python wrapper