Skip to content

Conversation

@TimoGlastra
Copy link
Contributor

Updates the JS wrapper:

  • updates all deps to latest version
  • moves to pnpm, vitest, and biome
  • update wrapper version to 0.3.0-dev.0 (if everything works fine we can directly release 0.3.0)

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@wadeking98
Copy link
Contributor

Also if it's not too much trouble do you mind incorporating the changes in from this PR? #270

Just the changes from these files:

  • wrappers/javascript/indy-vdr-nodejs/src/library/bindings.ts
  • wrappers/javascript/indy-vdr-nodejs/tests/IndyVdrTxnCache.test.ts
  • wrappers/javascript/indy-vdr-react-native/cpp/indyVdr.cpp
  • wrappers/javascript/indy-vdr-react-native/cpp/turboModuleUtility.cpp

otherwise I can do it in a separate PR if you'd prefer

@TimoGlastra
Copy link
Contributor Author

Also if it's not too much trouble do you mind incorporating the changes in from this PR? #270

Just the changes from these files:

  • wrappers/javascript/indy-vdr-nodejs/src/library/bindings.ts

  • wrappers/javascript/indy-vdr-nodejs/tests/IndyVdrTxnCache.test.ts

  • wrappers/javascript/indy-vdr-react-native/cpp/indyVdr.cpp

  • wrappers/javascript/indy-vdr-react-native/cpp/turboModuleUtility.cpp

otherwise I can do it in a separate PR if you'd prefer

Yes, will do!

@TimoGlastra
Copy link
Contributor Author

TimoGlastra commented Jun 12, 2024

@berendsliedrecht @andrewwhitehead any idea why the macOS build is suddenly failing? Only made changes to the JS wrapper

@wadeking98
Copy link
Contributor

wadeking98 commented Jun 14, 2024

@TimoGlastra not sure why it's just failing for the mac build, try updating time to 0.3.36 in the Cargo.toml file in libindy_vdr

Berend Sliedrecht and others added 2 commits June 17, 2024 16:53
Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Contributor Author

Still failing sadly @berendsliedrecht

@TimoGlastra
Copy link
Contributor Author

Now sure what is happening with the segmentation vault now ... :/

@berendsliedrecht
Copy link
Contributor

@TimoGlastra could it be related to vitest?

@TimoGlastra
Copy link
Contributor Author

Yeah maybe 🤷 Haven't found the time to look into it yet :(

Signed-off-by: Timo Glastra <timo@animo.id>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants