Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the data model reference to the latest iroha dev revision #485

Merged
merged 4 commits into from
May 15, 2024

Conversation

DCNick3
Copy link
Contributor

@DCNick3 DCNick3 commented May 14, 2024

This PR does three things:

While the inclusion of toml templates in place of old json files makes the config documentation "wrong", this allows writing new documentation with references to a more up-to-date schema.json.

In the end I think the #397 will in the end remove the toml templates altogether, I consider this just a way to unblock my updates to the torii reference for hyperledger-iroha/iroha#4544

@0x009922 Do you think it's a good approach? Or should we try somehow to keep the old json's in place while the new config reference is not yet complete?

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iroha-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 2:41pm

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
…g paths

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
…4544

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
@DCNick3
Copy link
Contributor Author

DCNick3 commented May 14, 2024

As CI was failing due to broken links to Versioned* structures, I went ahead and included torii reference updates as well, as most of the broken links was from the query endpoint anyway

@0x009922 0x009922 self-assigned this May 15, 2024
@DCNick3 DCNick3 merged commit 070bb2e into hyperledger-iroha:main May 15, 2024
5 checks passed
@0x009922
Copy link
Contributor

Do you think it's a good approach? Or should we try somehow to keep the old json's in place while the new config reference is not yet complete?

I think it's totally fine. Thank you for updating schema generation too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants