Remove Redis dependencies #1014

igor-egorov · 2018-02-27T13:22:43Z

Description of the Change

Redis dependencies were removed from docker-compose files, configuration files and all the rest places where Redis was mentioned.

Benefits

Completely removes Redis from the project after hyperledger-iroha/iroha#933

muratovv · 2018-02-27T13:30:45Z

deploy/ansible/roles/iroha-node/tasks/ubuntu.yml

@@ -81,6 +71,4 @@
        POSTGRES_PORT: 5432        
        POSTGRES_USER: "{{ postgresUser }}"
        POSTGRES_PASSWORD: "{{ postgresPassword }}"
-        REDIS_HOST: "{{ redisName }}"
-        REDIS_PORT: 6379
        KEY: node{{ key }}


Add end line. Also, configure up your IDE with auto-insertion of end line

muratovv · 2018-02-27T13:32:31Z

docs/source/deployment.rst


-By local environment, it is meant to have daemon process and the components (Redis and Postgres) deployed without any containers. This might be helpful in cases when messing up with Docker is not preferred — generally a quick exploration of the features.
+By local environment, it is meant to have daemon process and the components (Postgres) deployed without any containers. This might be helpful in cases when messing up with Docker is not preferred — generally a quick exploration of the features.


and the components (Postgres) deployed

Maybe rework it with

...and Postgres deployed...

muratovv · 2018-02-27T13:36:34Z

docs/source/deployment.rst

@@ -43,7 +38,7 @@ In case of valid assumptions, the only thing that remains is to launch the daemo
 +---------------+-----------------------------------------------------------------+
 | Parameter     | Meaning                                                         |
 +---------------+-----------------------------------------------------------------+
-| config        | configuration file, containing postgres, and redis connection,  |
+| config        | configuration file, containing postgres,                        |
 |               | and values to tune the system                                   |


If it possible fit this to the previous line.

Alexey-N-Chernyshov · 2018-02-27T14:08:35Z

docs/source/deployment.rst

@@ -43,8 +38,8 @@ In case of valid assumptions, the only thing that remains is to launch the daemo
 +---------------+-----------------------------------------------------------------+
 | Parameter     | Meaning                                                         |
 +---------------+-----------------------------------------------------------------+
-| config        | configuration file, containing postgres, and redis connection,  |
-|               | and values to tune the system                                   |
+| config        | configuration file, containing postgres connection, and values  |


extra comma after connection

Alexey-N-Chernyshov · 2018-02-27T14:09:09Z

docs/source/deployment.rst

@@ -77,23 +72,11 @@ Then, you have to create an enviroment for the image to run without problems:
 Create docker network
 """""""""""""""""""""

-Containers for Redis, Postgres, and Iroha should run in the same virtual network, in order to be available to each other. Create a network, by typing following command (you can use any name for the network, but in the example, we use *iroha-network* name): 
+Containers for Postgres, and Iroha should run in the same virtual network, in order to be available to each other. Create a network, by typing following command (you can use any name for the network, but in the example, we use *iroha-network* name):


extra comma after Postgres

Alexey-N-Chernyshov · 2018-02-27T14:09:30Z

docs/source/deployment.rst

@@ -122,7 +105,7 @@ Running iroha daemon in docker container
 """"""""""""""""""""""""""""""""""""""""

 There is a list of assumptions which you should review before proceeding:
- * Postgres and redis servers are running on the same docker network
+ * Postgres server are running on the same docker network


server is running

Alexey-N-Chernyshov · 2018-02-27T14:10:01Z

scripts/local-develop.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash

 #
-# This simple script starts redis and postgres docker containers,
+# This simple script starts postgres docker containers,


postgres docker container

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>

codecov · 2018-02-27T15:07:14Z

Codecov Report

Merging #1014 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1014   +/-   ##
========================================
  Coverage    33.06%   33.06%           
========================================
  Files          524      524           
  Lines        15990    15990           
  Branches     10182    10182           
========================================
  Hits          5287     5287           
  Misses        1371     1371           
  Partials      9332     9332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5a13e...60b192b. Read the comment docs.

PR was updated

lebdron

It would also be great to fix comments in postgres_block_query.hpp, because pull request descriptions states:

all the rest places where Redis was mentioned

neewy · 2018-02-28T07:02:16Z

For the sake of complete corrections maybe iroha-api modification is required.

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>

igor-egorov · 2018-02-28T07:15:40Z

Corrections suggested by @lebdron have been applied in 60b192b

sorabot · 2018-02-28T07:27:15Z

SonarQube analysis reported 5 issues

postgres_block_query.cpp#L144: Define a constant instead of duplicating this literal " AND height = " 2 times.
postgres_block_query.hpp#L72: Unused private function: 'PostgresBlockQuery::getBlockIds'
postgres_block_query.hpp#L80: Unused private function: 'PostgresBlockQuery::getBlockId'
postgres_block_query.hpp#L90: Unused private function: 'PostgresBlockQuery::callback'
postgres_block_query.hpp#L44: Undocumented API: PostgresBlockQuery

neewy · 2018-02-28T15:49:41Z

please use feature prefix for new changes as stated here https://github.com/hyperledger/iroha/wiki/Iroha-working-agreement#243-feature

igor-egorov · 2018-03-01T07:48:09Z

@neewy, thanks for the link! I have taken this into account. Since I have to rename the branch, this PR will be automatically closed and another will be issued instead.

I have prepared complementary PR for iroha-api repository - hyperledger-iroha/iroha-api#58

igor-egorov requested a review from muratovv February 27, 2018 13:23

MizukiSonoko added the in progress label Feb 27, 2018

igor-egorov changed the base branch from master to develop February 27, 2018 13:23

igor-egorov requested review from Alexey-N-Chernyshov and lebdron February 27, 2018 13:24

muratovv previously requested changes Feb 27, 2018

View reviewed changes

igor-egorov force-pushed the IR-952-remove-redis-deps branch 2 times, most recently from d5ec5a2 to 173ae6f Compare February 27, 2018 13:59

Alexey-N-Chernyshov suggested changes Feb 27, 2018

View reviewed changes

Remove Redis dependencies

2838679

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>

igor-egorov force-pushed the IR-952-remove-redis-deps branch from 173ae6f to 2838679 Compare February 27, 2018 15:06

igor-egorov requested a review from muratovv February 27, 2018 15:10

Alexey-N-Chernyshov approved these changes Feb 27, 2018

View reviewed changes

muratovv removed the in progress label Feb 28, 2018

lebdron approved these changes Feb 28, 2018

View reviewed changes

Remove redundant Redis mentions

60b192b

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>

igor-egorov closed this Mar 1, 2018

igor-egorov deleted the IR-952-remove-redis-deps branch March 1, 2018 07:55

igor-egorov mentioned this pull request Mar 1, 2018

Remove redundant Redis dependencies and mentions #1024

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Redis dependencies #1014

Remove Redis dependencies #1014

igor-egorov commented Feb 27, 2018 •

edited

Loading

muratovv Feb 27, 2018

muratovv Feb 27, 2018

muratovv Feb 27, 2018

Alexey-N-Chernyshov Feb 27, 2018

Alexey-N-Chernyshov Feb 27, 2018

Alexey-N-Chernyshov Feb 27, 2018

Alexey-N-Chernyshov Feb 27, 2018

codecov bot commented Feb 27, 2018 •

edited

Loading

lebdron left a comment

neewy commented Feb 28, 2018

igor-egorov commented Feb 28, 2018

sorabot commented Feb 28, 2018

neewy commented Feb 28, 2018

igor-egorov commented Mar 1, 2018 •

edited

Loading


		By local environment, it is meant to have daemon process and the components (Redis and Postgres) deployed without any containers. This might be helpful in cases when messing up with Docker is not preferred — generally a quick exploration of the features.
		By local environment, it is meant to have daemon process and the components (Postgres) deployed without any containers. This might be helpful in cases when messing up with Docker is not preferred — generally a quick exploration of the features.

Remove Redis dependencies #1014

Remove Redis dependencies #1014

Conversation

igor-egorov commented Feb 27, 2018 • edited Loading

Description of the Change

Benefits

muratovv Feb 27, 2018

Choose a reason for hiding this comment

muratovv Feb 27, 2018

Choose a reason for hiding this comment

muratovv Feb 27, 2018

Choose a reason for hiding this comment

Alexey-N-Chernyshov Feb 27, 2018

Choose a reason for hiding this comment

Alexey-N-Chernyshov Feb 27, 2018

Choose a reason for hiding this comment

Alexey-N-Chernyshov Feb 27, 2018

Choose a reason for hiding this comment

Alexey-N-Chernyshov Feb 27, 2018

Choose a reason for hiding this comment

codecov bot commented Feb 27, 2018 • edited Loading

Codecov Report

lebdron left a comment

Choose a reason for hiding this comment

neewy commented Feb 28, 2018

igor-egorov commented Feb 28, 2018

sorabot commented Feb 28, 2018

neewy commented Feb 28, 2018

igor-egorov commented Mar 1, 2018 • edited Loading

igor-egorov commented Feb 27, 2018 •

edited

Loading

codecov bot commented Feb 27, 2018 •

edited

Loading

igor-egorov commented Mar 1, 2018 •

edited

Loading